Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to ReadBuf API once stable #366

Closed
Thomasdezeeuw opened this issue Dec 21, 2022 · 3 comments
Closed

Consider switching to ReadBuf API once stable #366

Thomasdezeeuw opened this issue Dec 21, 2022 · 3 comments

Comments

@Thomasdezeeuw
Copy link
Collaborator

Instead of accepting &mut [MaybeUninit<u8>] in read/recv calls.

Tracking issue: rust-lang/rust#78485.

@Thomasdezeeuw
Copy link
Collaborator Author

Still not stable, so closing this.

@Darksonn
Copy link
Collaborator

You might want to call the methods _raw or similar to make space in the API for adding this in the future.

(Ignore me if you already do this.)

@Thomasdezeeuw
Copy link
Collaborator Author

I don't really want to do that for API such as recv_from_vectored: https://docs.rs/socket2/latest/socket2/struct.Socket.html#method.recv_from, which already has like 4 variants (6 if you count peeking), I don't want to double that. Though we should probably redesign that entire method to be honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants