Skip to content

Internal module names for x86 architecture intrinsics #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnzlbg opened this issue Nov 4, 2017 · 1 comment
Closed

Internal module names for x86 architecture intrinsics #169

gnzlbg opened this issue Nov 4, 2017 · 1 comment

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 4, 2017

In #166 I've added some architecture intrinsics (e.g. the cpuid intrinsic) to a misc module in x86.

Our internal module names are private and do not affect users, but IMO the name misc is pretty bad and we should group these intrinsics in a more consistent way.

We could name those modules .../i386/i486/i586/i686/... instead.

The main issue I have with this is that, for example, detecting i686 using target feature leads to:

if cfg!(all(target_arch = "x86", not(target_feature = "sse2"))) {

}

is IMO a bit messy.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 22, 2017

This split already happened.

@gnzlbg gnzlbg closed this as completed Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant