Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling overflow in fulfill #94

Open
lcnr opened this issue Feb 20, 2024 · 0 comments
Open

handling overflow in fulfill #94

lcnr opened this issue Feb 20, 2024 · 0 comments

Comments

@lcnr
Copy link
Contributor

lcnr commented Feb 20, 2024

rust-lang/rust#121322 changed overflow in fulfillment to simply return, simply treating them as ambiguous reevaluating the overflowing goals in the next call to select_where_possible. This does not impact coherence as it only uses a single call to select_where_possible.

Outside of coherence this can likely result in hangs and I believe we generally want some special diagnostics in case there's some overflow hitting the recursion limit. We may even want to fatally error when hitting them or something 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant