Add review-changes-since handler

a

Author: Urgau

src/config.rs

@@ -49,6 +49,7 @@ pub(crate) struct Config {
     pub(crate) behind_upstream: Option<BehindUpstreamConfig>,
     pub(crate) backport: Option<BackportConfig>,
     pub(crate) range_diff: Option<RangeDiffConfig>,
+    pub(crate) review_changes_since: Option<ReviewChangesSinceConfig>,
 }
 
 #[derive(PartialEq, Eq, Debug, serde::Deserialize)]
@@ -563,6 +564,12 @@ pub(crate) struct BackportRuleConfig {
 #[serde(deny_unknown_fields)]
 pub(crate) struct RangeDiffConfig {}
 
+/// Configuration for the changes since link on review body
+#[derive(Default, PartialEq, Eq, Debug, serde::Deserialize)]
+#[serde(rename_all = "kebab-case")]
+#[serde(deny_unknown_fields)]
+pub(crate) struct ReviewChangesSinceConfig {}
+
 fn get_cached_config(repo: &str) -> Option<Result<Arc<Config>, ConfigurationError>> {
     let cache = CONFIG_CACHE.read().unwrap();
     cache.get(repo).and_then(|(config, fetch_time)| {
@@ -704,6 +711,8 @@ mod tests {
             add-labels = ["stable-nominated"]
 
             [range-diff]
+
+            [review-changes-since]
         "#;
         let config = toml::from_str::<Config>(&config).unwrap();
         let mut ping_teams = HashMap::new();
@@ -795,6 +804,7 @@ mod tests {
                 }),
                 backport: Some(backport_team_config),
                 range_diff: Some(RangeDiffConfig {}),
+                review_changes_since: Some(ReviewChangesSinceConfig {}),
             }
         );
     }
@@ -884,6 +894,7 @@ mod tests {
                 }),
                 backport: None,
                 range_diff: None,
+                review_changes_since: None,
             }
         );
     }

src/github.rs

@@ -719,6 +719,33 @@ impl Issue {
         Ok(comment)
     }
 
+    pub async fn edit_review(
+        &self,
+        client: &GithubClient,
+        id: u64,
+        new_body: &str,
+    ) -> anyhow::Result<()> {
+        let comment_url = format!(
+            "{}/pulls/{}/reviews/{}",
+            self.repository().url(client),
+            self.number,
+            id
+        );
+        #[derive(serde::Serialize)]
+        struct NewComment<'a> {
+            body: &'a str,
+        }
+        client
+            .send_req(
+                client
+                    .put(&comment_url)
+                    .json(&NewComment { body: new_body }),
+            )
+            .await
+            .context("failed to edit review comment")?;
+        Ok(())
+    }
+
     pub async fn post_comment(&self, client: &GithubClient, body: &str) -> anyhow::Result<Comment> {
         #[derive(serde::Serialize)]
         struct PostComment<'a> {

src/handlers.rs

@@ -53,6 +53,7 @@ pub mod pull_requests_assignment_update;
 mod relabel;
 mod relnotes;
 mod rendered_link;
+mod review_changes_since;
 mod review_requested;
 mod review_submitted;
 pub mod rustc_commits;
@@ -160,6 +161,20 @@ pub async fn handle(ctx: &Context, host: &str, event: &Event) -> Vec<HandlerErro
         }
     }
 
+    if let Some(config) = config
+        .as_ref()
+        .ok()
+        .and_then(|c| c.review_changes_since.as_ref())
+    {
+        if let Err(e) = review_changes_since::handle(ctx, host, event, config).await {
+            log::error!(
+                "failed to process event {:?} with review_changes_since handler: {:?}",
+                event,
+                e
+            )
+        }
+    }
+
     if let Some(ghr_config) = config
         .as_ref()
         .ok()

src/handlers/review_changes_since.rs

@@ -0,0 +1,55 @@
+use anyhow::Context as _;
+
+use crate::{
+    config::ReviewChangesSinceConfig,
+    github::{Comment, Event, Issue, IssueCommentAction, IssueCommentEvent},
+    handlers::Context,
+};
+
+/// Checks if this event is a PR review creation and adds in the body a link our `gh-changes-since`
+/// endpoint to view changes since this review.
+pub(crate) async fn handle(
+    ctx: &Context,
+    host: &str,
+    event: &Event,
+    _config: &ReviewChangesSinceConfig,
+) -> anyhow::Result<()> {
+    if let Event::IssueComment(
+        event @ IssueCommentEvent {
+            action: IssueCommentAction::Created,
+            issue: Issue {
+                pull_request: Some(_),
+                ..
+            },
+            comment:
+                Comment {
+                    pr_review_state: Some(_),
+                    ..
+                },
+            ..
+        },
+    ) = event
+    {
+        // Add link our gh-changes-since endpoint to view changes since this review
+
+        let issue_repo = event.issue.repository();
+        let pr_num = event.issue.number;
+
+        let base = &event.issue.base.as_ref().context("no base")?.sha;
+        let head = &event.issue.head.as_ref().context("no head")?.sha;
+
+        let link = format!("https://{host}/gh-changes-since/{issue_repo}/{pr_num}/{base}..{head}");
+        let new_body = format!(
+            "{}\n\n*[View changes since this review]({link})*",
+            event.comment.body
+        );
+
+        event
+            .issue
+            .edit_review(&ctx.github, event.comment.id, &new_body)
+            .await
+            .context("failed to update the review body")?;
+    }
+
+    Ok(())
+}