Caller checks review capacity DB query result

Author: apiraino

src/handlers/assign.rs

@@ -541,18 +541,17 @@ pub(super) async fn handle_command(
                 }
                 let db_client = ctx.db.get().await;
                 if is_self_assign(&name, &event.user().login) {
-                    match has_user_capacity(&db_client, &name).await {
-                        Ok(work_queue) => work_queue.username,
-                        Err(_) => {
-                            issue
-                                .post_comment(
-                                    &ctx.github,
-                                    &REVIEWER_HAS_NO_CAPACITY.replace("{username}", &name),
-                                )
-                                .await?;
-                            return Ok(());
-                        }
-                    };
+                    let work_queue = has_user_capacity(&db_client, &name).await;
+                    if work_queue.is_err() {
+                        issue
+                            .post_comment(
+                                &ctx.github,
+                                &REVIEWER_HAS_NO_CAPACITY.replace("{username}", &name),
+                            )
+                            .await?;
+                        return Ok(());
+                    }
+
                     name.to_string()
                 } else {
                     let teams = crate::team_data::teams(&ctx.github).await?;

src/handlers/pr_tracking.rs

@@ -105,7 +105,6 @@ pub(super) async fn handle_input<'a>(
     Ok(())
 }
 
-// TODO: we should just fetch the number of assigned prs and max assigned prs. The caller should do the check.
 pub async fn has_user_capacity(
     db: &crate::db::PooledClient,
     assignee: &str,