Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Label X can only be set by Rust team members" when label doesn't exist #1721

Open
tgross35 opened this issue Sep 19, 2023 · 2 comments
Open
Labels
A-labeling Area: label command

Comments

@tgross35
Copy link
Contributor

It seems like trying to label something if it doesn't exist gives an insufficient permissions error, rather than some sort of "label not found" error which would make more sense. Example:

rust-lang/rust#115719 (comment)

Also from that example, maybe labels should be checked case insensitive

@ehuss
Copy link
Contributor

ehuss commented Sep 19, 2023

I think the issue there is just the case-sensitivity check for permissions. Generally, GitHub is case-insensitive for labels, but the triagebot code here is not. I believe glob supports case-insensitive matching, and a PR to update that would be welcome.

@ehuss ehuss added the A-labeling Area: label command label Sep 19, 2023
@tgross35
Copy link
Contributor Author

Thanks, I made the matching case insensistive in #1722. I still think the message could be improved - even if someone does @rustbot label +definitely-doesnt-exist it should say that the label doesn't exist rather than that permissions aren't sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-labeling Area: label command
Projects
None yet
Development

No branches or pull requests

2 participants