Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust installation not shown properly on illumos #1827

Open
Noratrieb opened this issue Jun 21, 2023 · 3 comments
Open

rust installation not shown properly on illumos #1827

Noratrieb opened this issue Jun 21, 2023 · 3 comments
Labels
A-Content The written content on the website. C-Bug Something isn't working.

Comments

@Noratrieb
Copy link
Member

What needs to be fixed?

image

navigator.platform: SunOS i86pc
navigator.appVersion: 5.0 (X11)

I am using x86_64-unknown-illumos, a tier 2 target with host tools. The unix installation method works (except I have to | bash instead of | sh which rustup-init.sh would have suggested when I ran it if it wasn't for rust-lang/rustup#3388)

I guess the user agent really badly reflects the fact that I am using illumos and not some ancient solaris so I'm not sure whether this is worth changing.

Page(s) Affected

https://www.rust-lang.org/tools/install

Suggested Improvement

Detect SunOS and mention that illumos has host tools. I'm not sure whether this is worth improving, but I'll open the issue anyways in case anyone else hits it too.

@Noratrieb Noratrieb added A-Content The written content on the website. C-Bug Something isn't working. labels Jun 21, 2023
@Manishearth
Copy link
Member

cc @hi-rustin @rbtcollins Is this an explicitly supported platform for Rustup, and if so should we include this on the website?

@rbtcollins
Copy link

Rustup doesn't really have explicitly supported or anything: we accept any (good condition) patches to help platforms move up tiers, and as that newly filed rustup bug on the installation script shows, illumos is closing in on having everything working.

I think detecting the correct platform and showing the normal download instructions would be good.

I don't know whether illumos should change their default user-agent a bit first or not, because SunOS 4.1 is 28 years old now...

Might it make sense to always show the curlsh pattern, but for unknown hosts include a caveat (that whether it will work or not will depend on whether that tier has complete host tool support?

@Manishearth
Copy link
Member

I think that would be fine if the rustup team supports it.

Would be open to accepting such a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Content The written content on the website. C-Bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

4 participants
@rbtcollins @Manishearth @Noratrieb and others