Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo: Handle errors properly in cargo-marker #169

Closed
xFrednet opened this issue Jul 11, 2023 · 3 comments · Fixed by #231
Closed

Cargo: Handle errors properly in cargo-marker #169

xFrednet opened this issue Jul 11, 2023 · 3 comments · Fixed by #231
Assignees
Labels
A-marker-cargo Area: All things connected to `cargo_marker` C-enhancement Category: New feature or request E-good-first-issue Participation: Good for newcomers
Milestone

Comments

@xFrednet
Copy link
Member

cargo-marker interacts a lot with other programs or the file system. Therefore, it has to handle numerous Result<X, Y> types. Currently, every error is just mapped to a single ExitStatus enum, that provides very little information. This is not ideal...

  • It might be good to use an existing library for error handling.
  • Errors should provide as much information as possible.
  • Only the CLI part of cargo_marker should "know" what an exit status is.
@xFrednet xFrednet added C-enhancement Category: New feature or request A-marker-cargo Area: All things connected to `cargo_marker` E-good-first-issue Participation: Good for newcomers labels Jul 11, 2023
@xFrednet
Copy link
Member Author

xFrednet commented Jul 11, 2023

This issue should be a good first issue for everyone, that has a bit of experience with proper error handling in Rust. :)

@xFrednet xFrednet self-assigned this Jul 19, 2023
@xFrednet xFrednet added this to the v0.2.0 milestone Jul 25, 2023
@xFrednet xFrednet removed their assignment Jul 26, 2023
@xFrednet xFrednet modified the milestones: v0.2.0, v0.3.0 Aug 18, 2023
@Veetaha
Copy link
Contributor

Veetaha commented Aug 23, 2023

I'd like to take this issue

@xFrednet
Copy link
Member Author

You're very welcome to, feel free to add the dependencies you already mentioned previously :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-marker-cargo Area: All things connected to `cargo_marker` C-enhancement Category: New feature or request E-good-first-issue Participation: Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants