Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support async blocks and await expressions #174

Closed
xFrednet opened this issue Jul 14, 2023 · 1 comment · Fixed by #197
Closed

Support async blocks and await expressions #174

xFrednet opened this issue Jul 14, 2023 · 1 comment · Fixed by #197
Assignees
@xFrednet
Labels
A-api Area: Stable API C-enhancement Category: New feature or request D-rustc-driver Driver: Rustc Driver E-help-wanted Participation: Issues with some complexity and where help would be highly appreciated
Milestone
v0.2.0

Comments

@xFrednet
Copy link
Member

xFrednet commented Jul 14, 2023 •
edited
Loading

Marker is currently still missing a stable representation for async blocks and await expressions. For now, these will be transformed into an UnstableExpr and a note will be printed notifying the used.

Async blocks and await expressions are quite complicated, which is the main reason why they are missing. Rust desugars them into several sub expressions with different LangItems. Other expressions, like for loops are resugared by marker to make linting more pleasant and hide the specific implementation the driver choose. For async blocks and await expressions, it would be good to do the same. However, that's a beast I just haven't dared to touch.

Until that time, please use this issue to share await and async code snippets which can be used for testing when that beast is finally tackled.

The MARKER_DISABLE_ASYNC_WARNING environment value can be used to disable the warnings. You might have to clean the project first for the value to take effect.
@xFrednet xFrednet added C-enhancement Category: New feature or request E-help-wanted Participation: Issues with some complexity and where help would be highly appreciated A-api Area: Stable API D-rustc-driver Driver: Rustc Driver labels Jul 14, 2023
This was referenced Jun 3, 2023
Closed
Open
Closed
@xFrednet
Copy link
Member Author

This will be fun...

@xFrednet xFrednet self-assigned this Jul 24, 2023
@xFrednet xFrednet added this to the v0.2.0 milestone Jul 25, 2023
@xFrednet xFrednet mentioned this issue Jul 25, 2023
Merged
@bors bors bot closed this as completed in 2bf48e1 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xFrednet xFrednet

Labels
A-api Area: Stable API C-enhancement Category: New feature or request D-rustc-driver Driver: Rustc Driver E-help-wanted Participation: Issues with some complexity and where help would be highly appreciated
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

API, Rustc: Add AwaitExpr and support async blocks and fns xFrednet/marker
1 participant
@xFrednet