-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Make serde an optional dependency #48
Comments
This sounds like a good idea, thanks for pointing this out! We're currently contributing a lot of changes for a 0.2 version, so the minor version update is not a problem IMO. |
we can't move the serde dependency behind a feature flag for |
I just merged a PR in |
Update: We just need to bump |
Closed by #289 |
One suggestion to prevent bringing in more dependencies than a user needs would be to make serde an optional dependency and adjust the
Serialize
andDeserialize
derives be like#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
. This would be a breaking change so would need a minor version update.The text was updated successfully, but these errors were encountered: