Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Make serde an optional dependency #48

Closed
xd009642 opened this issue Sep 27, 2020 · 5 comments
Closed

Suggestion: Make serde an optional dependency #48

xd009642 opened this issue Sep 27, 2020 · 5 comments
Labels
infrastructure General tasks effecting all implementations

Comments

@xd009642
Copy link
Member

One suggestion to prevent bringing in more dependencies than a user needs would be to make serde an optional dependency and adjust the Serialize and Deserialize derives be like #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]. This would be a breaking change so would need a minor version update.

@paulkoerbitz
Copy link
Collaborator

This sounds like a good idea, thanks for pointing this out! We're currently contributing a lot of changes for a 0.2 version, so the minor version update is not a problem IMO.

@bytesnake
Copy link
Member

we can't move the serde dependency behind a feature flag for linfa-linear and linfa-logistic because of argmin

@bytesnake bytesnake added the infrastructure General tasks effecting all implementations label Jul 22, 2021
@stefan-k
Copy link
Contributor

I just merged a PR in argmin which adds a feature that allows users to remove the serde dependency. This isn't released yet though and unfortunately I can't make any promises yet as to when there will be a new release.

@YuhanLiin
Copy link
Collaborator

Update: We just need to bump argmin in linfa-logistic and linfa-ftrl to 0.7, the same way it was done in linfa-linear.

@relf
Copy link
Member

relf commented Jan 7, 2025

Closed by #289

@relf relf closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure General tasks effecting all implementations
Projects
None yet
Development

No branches or pull requests

6 participants