Skip to content

Commit 700b4dd

Browse files
committed
scripts: Fix off by one in makechangelog
Use git's tformat to get a newline on the last entry, and then we include the last commit hash in the listing too.
1 parent f563af0 commit 700b4dd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/makechangelog.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
# Will produce some duplicates for PRs integrated using rebase,
99
# but those will not occur with current merge queue.
1010

11-
git log --first-parent --pretty="format:%H" "$@" | while read commit_sha
11+
git log --first-parent --pretty="tformat:%H" "$@" | while IFS= read -r commit_sha
1212
do
1313
gh api "/repos/:owner/:repo/commits/${commit_sha}/pulls" \
1414
-q ".[] | \"- \(.title) by [@\(.user.login)](\(.user.html_url)) [#\(.number)](\(.html_url))\""

0 commit comments

Comments
 (0)