Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MapperAllSizes to Translate? #152

Closed
phil-opp opened this issue Apr 23, 2020 · 3 comments
Closed

Rename MapperAllSizes to Translate? #152

phil-opp opened this issue Apr 23, 2020 · 3 comments

Comments

@phil-opp
Copy link
Member

The MapperAllSizes trait currently provides only methods for translating addresses. While it is currently a supertrait of Mapper<{Size4KiB, Size2MiB, Size1GiB}, this isn't really required for any of its methods. It might thus be a good idea to remove the supertrait relationship and rename the trait to e.g. Translate.
@phil-opp phil-opp mentioned this issue Apr 23, 2020
Closed
@josephlr josephlr mentioned this issue Oct 16, 2020
Closed
14 tasks
@phil-opp
Copy link
Member Author

It might be worth keeping MapperAllSizes as an alias for Mapper<{Size4KiB, Size2MiB, Size1GiB} (without any additional methods).

@phil-opp phil-opp mentioned this issue Dec 28, 2020
Merged
@mental32
Copy link
Member

Triage: should this be closed on account of #211 ?

@phil-opp
Copy link
Member Author

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phil-opp @mental32