Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable unsafe_block_in_unsafe_fn feature #221

Closed
phil-opp opened this issue Dec 28, 2020 · 3 comments · Fixed by #328
Closed

Enable unsafe_block_in_unsafe_fn feature #221

phil-opp opened this issue Dec 28, 2020 · 3 comments · Fixed by #328

Comments

@phil-opp
Copy link
Member

See rust-lang/rust#71668
@josephlr
Copy link
Contributor

We will have to wait for that lint to stabilize, right? Otherwise it seems like it would be hard to keep things warning free on both stable and nightly.

@phil-opp
Copy link
Member Author

We could allow the unused_unsafe lint on stable to avoid the warnings.

@josephlr
Copy link
Contributor

josephlr commented May 6, 2021

#![deny(unsafe_op_in_unsafe_fn)] is stable, see rust-lang/rust#79208!

So we can just add this whenever

@josephlr josephlr mentioned this issue May 14, 2021
Merged
@Freax13 Freax13 mentioned this issue Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable unsafe_block_in_unsafe_fn lint Freax13/x86_64
2 participants
@phil-opp @josephlr