Hermit: use sys_read_entropy syscall #333
Conversation
|
I agree that handing which platform Hermit supports is not our job, so this implementation should be fine. Could we add a documentation link? |
|
I couldn't find a documentation to which we could link, so the only option for now is to link the source code. I am not sure such link would be useful. |
I think linking to the system crate (which is the preferred interface to Hermit) would be appropriate: https://hermitcore.github.io/libhermit-rs/hermit/fn.sys_read_entropy.html |
|
Ah, good find! |
This link is broken... |
|
@hugusmaximus |
|
Yes, I found this info too... I was s bit confused. Thanks.
El jue., 4 ene. 2024 21:38, Artyom Pavlov ***@***.***>
escribió:
… @hugusmaximus <https://github.com/hugusmaximus>
The documentation <https://docs.rs/getrandom> currently uses this link
<https://github.com/hermit-os/kernel/blob/315f58ff5efc81d9bf0618af85a59963ff55f8b1/src/syscalls/entropy.rs#L47-L55>
.
—
Reply to this email directly, view it on GitHub
<#333 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQVGKU2ITM6UXBNQRM4F7K3YM4HNTAVCNFSM6AAAAAAUIC72RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXG4ZTAMBTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The syscall was implemented in hermit-os/kernel#640
On non-x86 targets it will return
-ENOSYS(which, frankly, IMO is quite bad), but I would say it's outside of our area of responsibility.cc @joboet @stlankes