Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockRng64 doesn't implement CryptoRng #1371

Closed
Pr0methean opened this issue Jan 8, 2024 · 3 comments
Closed

BlockRng64 doesn't implement CryptoRng #1371

Pr0methean opened this issue Jan 8, 2024 · 3 comments

Comments

@Pr0methean
Copy link

Problem: Although rand has the declaration

impl<R: BlockRngCore + CryptoRng> CryptoRng for BlockRng<R> {}

there's no equivalent for BlockRng64<R>, so a BlockRng64 can't pass any compile-time check for a CryptoRng even when the core does.

@dhardy
Copy link
Member

dhardy commented Jan 16, 2024

This was already changed in master: #1273

And, yes, that's not released yet; there's a tracking issue for version 0.9 if you're interested.

@dhardy dhardy closed this as completed Jan 16, 2024
@conradludgate
Copy link

Any reason why

impl<R: BlockRngCore + CryptoRng> CryptoRng for BlockRng64<R> {}

cannot be backported to rand_core 0.6.X?

What's the ETA on rand 0.9 (I couldn't find a tracking issue)?

@dhardy
Copy link
Member

dhardy commented Jan 26, 2025

It may be possible to backport, but we haven't usually bothered. If you need a backport, open a PR against the 0.8 branch (or a new issue if you can't find the appropriate branch).

Rand v0.9 should be released tomorrow. You can use the latest beta release for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants