-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Think about Isaac{,64}Rng #15
Comments
These names are chosen to reflect the names of the algorithms, which are ISAAC and ISAAC64 respectively. (That's not to say we can't deviate, but it is a bit of weight toward the status quo.) |
An update an the oldest open issue in #14 was merged in a Interestingly ISAAC-64 is faster than ISAAC on 32-bit, see dhardy#53. The only advantage of ISAAC over the 64-bit version is that it uses half the memory. We still have
|
You're probably benchmarking only modern Intel CPUs? ARMv7 for one might be quite different. No, we probably don't want that branch; the point of Lets close this; the current names are good enough and we may well remove them from |
Currently we provide two versions of Isaac RNG, namely a 32-bit and 64-bit version. One fitting the machine word size was previously (before #14) chosen automagically by
StdRng
. This means currently using a matching IsaacRng version needs to use#[cfg]
conditional comments in the client code.We need to decide whether we want to remove Isaac*Rng from the rand crate or rename current
IsaacRng
toIsaac32Rng
and addIsaacRng
which selects the best implementation.The text was updated successfully, but these errors were encountered: