Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling source files with invalid utf8: lossy conversion to string #29

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

alexmaco
Copy link
Contributor

@alexmaco alexmaco commented Dec 1, 2018

Some projects, like bat, use invalid UTF8 is source files on purpose. This ensures cargo-geiger doesn't crash when Read::read_to_string fails due to encoding issues, and still parses the file.

@anderejd
Copy link
Contributor

anderejd commented Dec 3, 2018

This makes perfect sense to me.

Thanks for the bat link btw! Looks like I'll be using it instead of cat.

@anderejd anderejd merged commit 64e5052 into geiger-rs:master Dec 3, 2018
@alexmaco alexmaco deleted the invalid_utf8_source branch January 22, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants