Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark no_mangle functions as unsafe #173

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Mark no_mangle functions as unsafe #173

merged 2 commits into from
Jan 19, 2021

Conversation

qrilka
Copy link
Contributor

@qrilka qrilka commented Jan 14, 2021

Resolves #104

@qrilka qrilka force-pushed the 104-mark-no_mangle-as-unsafe branch from e0c4d9c to 069e99e Compare January 14, 2021 12:22
@Nemo157
Copy link

Nemo157 commented Jan 15, 2021

This should also apply to #[export_name = "..."].

@qrilka
Copy link
Contributor Author

qrilka commented Jan 19, 2021

Added export_name as well.
@anderejd could I ask for a feedback on my PRs?

@anderejd
Copy link
Contributor

Hey, thanks for the PR and sorry for the delay!

Looks great!

@anderejd anderejd merged commit 5bcba4f into geiger-rs:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect and report #[no_mangle]
3 participants
@qrilka @Nemo157 @anderejd