Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsock: it doesn't work with crosvm #408

Closed
ikicha opened this issue Jul 26, 2023 · 2 comments · Fixed by #409
Closed

vsock: it doesn't work with crosvm #408

ikicha opened this issue Jul 26, 2023 · 2 comments · Fixed by #409

Comments

@ikicha
Copy link
Contributor

ikicha commented Jul 26, 2023

crosvm expects there are 3 queues: rx, tx, event. but vhost-user-vsock declares only 2 vqs, and it causes the problem in crosvm.

even qemu, it looks like they uses 3 queues: https://github.com/qemu/qemu/blob/6cb2011fedf8c4e7b66b4a3abd6b42c1bae99ce6/include/hw/virtio/vhost-vsock-common.h#L33

@ikicha
Copy link
Contributor Author

ikicha commented Jul 26, 2023

@stefano-garzarella
Copy link
Member

a vhost-user device is not a complete offload of a virtio device (as vDPA is), so it is fine that a vhost-user device handles only a subset of the queues.

For vsock, we are doing like for the vhost-vsock in-kernel device, and we handle only TX and RX, since QEMU for example is handling the event VQ: https://github.com/qemu/qemu/blob/6cb2011fedf8c4e7b66b4a3abd6b42c1bae99ce6/hw/virtio/vhost-vsock-common.c#L259

Can you describe better the issue with crosvm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants