Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement builder for MmapRegion #149

Closed
jiangliu opened this issue Jun 7, 2021 · 1 comment
Closed

Implement builder for MmapRegion #149

jiangliu opened this issue Jun 7, 2021 · 1 comment
Assignees
@jiangliu
Labels
enhancement New feature or request next-release

Comments

@jiangliu
Copy link
Member

jiangliu commented Jun 7, 2021

Currently the MmapRegion provides several methods to create MmapRegion objects, but we often need to change the existing methods to support new functionalities. So it would be better to adopt Builder pattern and implement MmapRegionBuilder, so we could add new functionality without affecting existing users.
@jiangliu jiangliu self-assigned this Jun 7, 2021
@jiangliu jiangliu added enhancement New feature or request next-release labels Jun 7, 2021
@jiangliu jiangliu mentioned this issue Jun 7, 2021
Merged
@jiangliu
Copy link
Member Author

jiangliu commented Aug 3, 2021

closed while #155

@jiangliu jiangliu closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiangliu jiangliu

Labels
enhancement New feature or request next-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiangliu