Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titlebar looks weird under wayland #1044

Closed
binomial0 opened this issue Jul 9, 2018 · 3 comments
Closed

Titlebar looks weird under wayland #1044

binomial0 opened this issue Jul 9, 2018 · 3 comments

Comments

@binomial0
Copy link

When I run the "window" example under Wayland, the window decorations are looking very unusual:
glutin_wayland
When I use xorg instead, it all looks like expected:
glutin_xorg

This affects several downstream projects, including alacritty and Servo.

System information:
Ubuntu 18.04 64bit, Gnome 3.28.1, Display driver: radeon

@francesca64
Copy link
Member

This is an upstream issue that isn't directly related to glutin or winit: Smithay/wayland-window#19

Since Wayland requires clients to draw their own decorations, getting native results would require non-trivial time investment. I'd be interested in trying to design a better set of stock decorations, but I'd likely make them pink.

@binomial0
Copy link
Author

Thank you! I didn't know that.
Shipping your own set of decorations seems a bit out of scope for this project, but if there's no other option...
<mini-rant> I don't understand why Wayland requires you to do that, though. Window decorations seem like some basic functionality... but then again, I'm quite a noob regarding all this, so what do I know... </mini-rant>
Anyway, closing this, because the issue seems to be further upstream.

@elinorbgr
Copy link
Contributor

I don't understand why Wayland requires you to do that, though. Window decorations seem like some basic functionality...

To expand a little more on @francesca64 's explanations, decoration drawing is currently handled by SCTK (wayland-window is its predecessor).

Wayland requires a client to be able to draw its own decorations, as some compositors will not draw them for the clients (on example is Gnome's mutter). As such, I have implemented in SCTK a very basic decoration drawing. It aims at being functional rather than pretty, as I am no GUI designed. Any help to make them prettier would be very welcome though.

On the other hand, since a few days ago, there is now a protocol extension to allow negotiation between the client and the server of which will draw the decorations (as for example, KDE's Kwin can handle the decorations drawing, and tends to prefer doing it). I plan to integrate this protocol is SCTK at some point, and have an issue tracking it once I get the bandwidth for it (or someone else want to tackle it), and it'll also require other compositors to adopt this extension (hopefully KDE will switch to the standard one rather than its custom internal one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants