Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does RawWindowHandle need to be Copy? #138

Closed
grovesNL opened this issue Aug 5, 2023 · 3 comments · Fixed by #140
Closed

Does RawWindowHandle need to be Copy? #138

grovesNL opened this issue Aug 5, 2023 · 3 comments · Fixed by #140

Comments

@grovesNL
Copy link
Contributor

grovesNL commented Aug 5, 2023

It looks like the Copy derive was added in #18, I guess because each handle happened to be compatible with it at the time.

However there are some benefits to removing Copy, e.g. it makes it possible to include strongly typed web handles that are reference counted (not Copy) #134 (comment)

@Lokathor
Copy link
Contributor

Lokathor commented Aug 5, 2023

My vote would be that it doesn't need to be Copy.

People should be paying close attention to code using these values and an occasional .clone() won't hurt them

@notgull
Copy link
Member

notgull commented Aug 8, 2023

I like the idea of a window/display handle having the same semantics as an &T reference. However I'd not married to this idea, so if the general consensus is to remove Copy I would be all for it.

@kchibisov
Copy link
Member

Yeah, don't see nothing wrong with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants