Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for WindowBuilder::with_outer_position #1190

Closed
4 of 10 tasks
murarth opened this issue Sep 26, 2019 · 7 comments
Closed
4 of 10 tasks

Tracking issue for WindowBuilder::with_outer_position #1190

murarth opened this issue Sep 26, 2019 · 7 comments
Labels
DS - android DS - ios DS - web H - help wanted Someone please save us S - api Design and usability S - meta Project governance

Comments

@murarth
Copy link
Contributor

murarth commented Sep 26, 2019 •
edited
Loading

This issue tracks the implementation of WindowBuilder::with_outer_position, proposed in #806. PRs implementing this change should be made against the with_outer_position branch.
@sumit0190
Copy link

Is someone already on this for Windows? I have some local changes (using SetWindowPos) that I could easily sync with master once this goes in.

@goddessfreya
Copy link
Contributor

Afaik, no one has mentioned anything.

@Osspial Osspial mentioned this issue Oct 5, 2019
Merged
3 tasks
@cole-h cole-h mentioned this issue Nov 25, 2019
Closed
@parasyte parasyte mentioned this issue Feb 21, 2020
Closed
@lovesegfault lovesegfault mentioned this issue Apr 13, 2020
Closed
@emilk
Copy link
Contributor

emilk commented Sep 25, 2020

I would love to have this (on mac)

@hecrj hecrj mentioned this issue Oct 13, 2020
Closed
@stephentalley
Copy link

Did work on this fizzle out? Could we have a partial fix, even if it's just for X11/Windows?

@msiglreith
Copy link
Member

WindowBuilder::with_position got introduced in 0.25, which covers this issues I think. On MacOS, it doesn't seem to be possible to specify the outer position due to decorations but on Windows/X11 it will set the outer position.

(PR: #1866)

@emilk
Copy link
Contributor

emilk commented Sep 22, 2021

@msiglreith I just tested this now, and it works, even on my Mac! 🥳

Maybe this can be closed!?

@msiglreith
Copy link
Member

nice, thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DS - android DS - ios DS - web H - help wanted Someone please save us S - api Design and usability S - meta Project governance
Milestone
No milestone
Development

No branches or pull requests
6 participants
@emilk @murarth @stephentalley @msiglreith @sumit0190 @goddessfreya