Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X11] Missing key release event #1965

Closed
ghost opened this issue Jun 13, 2021 · 7 comments
Closed

[X11] Missing key release event #1965

ghost opened this issue Jun 13, 2021 · 7 comments
Labels
B - bug Dang, that shouldn't have happened C - needs investigation Issue must be confirmed and researched C - waiting on author Waiting for a response or another PR DS - x11

Comments

@ghost
Copy link

ghost commented Jun 13, 2021

So, our engine uses winit for windowing, and have encoutared this issues: FyroxEngine/Fyrox#108

What can cause this issue? A bug in winit or bug in the engine? The issue have some information too, look at the disscussion in the issue.

@maroider
Copy link
Member

From the issue you linked, it seems like the problem you're having looks like it's caused by a missing key release event, and I've changed the issue title to reflect that.

I'm going to need some more info in order to get a proper understanding of exactly what's going wrong, though.

  • Are you using WindowEvent or are you using DeviceEvent?
  • Does the issue only occur with a single key (e.g. only A or B), or are multiple keys affected?
  • What does resizing the window have to do with your issue?
  • Can you reproduce it with Winit only?
  • Can you reproduce it with my new-keyboard-linux ( New keyboard API for Linux #1932) branch?

@maroider maroider changed the title What can cause this problems? [X11] Missing key release event Jun 14, 2021
@maroider maroider added DS - x11 C - needs investigation Issue must be confirmed and researched B - bug Dang, that shouldn't have happened labels Jun 14, 2021
@ghost
Copy link
Author

ghost commented Jun 14, 2021

  • We use WindowEvent. It seems that there was some issue with inputting which made us switch from DeviceEvent to WindowEvent.
  • no, it isn't tied to these keys
  • there's no issues if the window hasn't been resized. Windows with original size don't have any issues.
  • [I haven't done it yet, will update my comment]
  • [in process of making it, will update my comment]

@maroider maroider added the C - waiting on author Waiting for a response or another PR label Jun 25, 2021
@ghost
Copy link
Author

ghost commented Jun 30, 2021

@maroider what is the replacement for VirtualKeyCode in the new version?

@maroider
Copy link
Member

Its closest analogue is the Key enum, but it's not quite the same (and for good reason).

@ghost
Copy link
Author

ghost commented Jun 30, 2021

Well, we use VirtualKeyCode Event, so will Key enum easy replace it?

@ghost
Copy link
Author

ghost commented Jul 2, 2021

@maroider what example I should choose for trying to reproducing this bug in winit only?

@maroider
Copy link
Member

maroider commented Jul 2, 2021

Ideally, you'd make your own minimal, reproducible example based off of the keyboard handling code in rg3d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened C - needs investigation Issue must be confirmed and researched C - waiting on author Waiting for a response or another PR DS - x11
Development

No branches or pull requests

2 participants