Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Proposal] Attach an empty buffer on new wayland surfaces #2089

Closed
Diegovsky opened this issue Dec 5, 2021 · 4 comments
Closed

[Feature Proposal] Attach an empty buffer on new wayland surfaces #2089

Diegovsky opened this issue Dec 5, 2021 · 4 comments
Labels
C - needs discussion Direction must be ironed out DS - wayland S - enhancement Wouldn't this be the coolest?

Comments

@Diegovsky
Copy link

I've stumbled upon a wayland bug caused by the protocol demanding that for a window to be shown (and also have some of it's properties available) it must be mapped, and it seems I'm not the first one: #1257, #793.

To solve this and to make wayland behave a bit more like other platforms (for ease of use), I propose mapping a bogus buffer (with undefined data) to the surface when creating it. Since we're already using SCTK anyways, that wouldn't be a hard task as it provides wrappers for simple memory buffers.

This would make examples work on wayland. I'm willing to submit a PR :)

@maroider maroider added DS - wayland C - needs discussion Direction must be ironed out S - enhancement Wouldn't this be the coolest? labels Dec 5, 2021
@kchibisov
Copy link
Member

The way for working examples is to use software rendering.

Attaching a null buffer will result in unmapping actually.

So the issue in the way it's created is out of scope.

@Diegovsky
Copy link
Author

I meant attaching a buffer filled with black pixels or garbage data, not a null buffer. I know that attaching a null buffer unmaps the surface.

Anyways, it seems that using soft rendering does fix it

@kchibisov
Copy link
Member

It'll cause issues for the OpenGL/Vulkan, like it already did.

For examples will use softbuffer.

@Diegovsky
Copy link
Author

ack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - needs discussion Direction must be ironed out DS - wayland S - enhancement Wouldn't this be the coolest?
Development

No branches or pull requests

3 participants