Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do PhysicalPosition and PhysicalSize use floats, not ints? #822

Closed
Osspial opened this issue Mar 21, 2019 · 1 comment
Closed

Why do PhysicalPosition and PhysicalSize use floats, not ints? #822

Osspial opened this issue Mar 21, 2019 · 1 comment
Labels
F - question There's no such thing as a stupid one S - api Design and usability

Comments

@Osspial
Copy link
Contributor

Osspial commented Mar 21, 2019 •
edited
Loading

Relatively small nitpick, but it seems like a weird choice. Physical coordinates represent the actual pixels on users' monitors, and none of the rendering APIs I'm familiar with (OpenGL, and I assume Vulkan) let you render to fractionally-sized framebuffers. All usage of them is going to require converting them to ints, so why don't we expose them as i32s?

cc @francesca64, as afaik she designed and implemented the current HiDPI API.
@Osspial Osspial added F - question There's no such thing as a stupid one S - api Design and usability labels Mar 21, 2019
@Osspial
Copy link
Contributor Author

Osspial commented Apr 25, 2019

Closing in favor of #837

@Osspial Osspial closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F - question There's no such thing as a stupid one S - api Design and usability
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Osspial