Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointer grab for Wayland #962

Closed
Cherser-s opened this issue Jun 22, 2019 · 6 comments · Fixed by #973
Closed

Add pointer grab for Wayland #962

Cherser-s opened this issue Jun 22, 2019 · 6 comments · Fixed by #973
Labels
DS - wayland S - api Design and usability S - enhancement Wouldn't this be the coolest?

Comments

@Cherser-s
Copy link
Contributor

pointer_constraints_v1 extension has been around for almost a year. It is already supported in wlroots.

@goddessfreya goddessfreya added DS - wayland S - api Design and usability S - enhancement Wouldn't this be the coolest? labels Jun 22, 2019
@elinorbgr
Copy link
Contributor

This will need to go through Smithay/client-toolkit#72

@Cherser-s
Copy link
Contributor Author

Does this functionality need to belong there? Seat manager isn't implemented in client-toolkit for example.

@elinorbgr
Copy link
Contributor

SCTK goal is to provide general abstractions facilitating the use of the various wayland protocol extensions. The seat manage is not provided by it because it contains mostly winit-specific code, but it uses SCTK for handling the translation of keyboard events for example.

In the same approach, I expect the support of pointer-constraints and relative-pointer will caontain both winit-specific code and code that may be re-used in other apps. The latter part could live in SCTK to improve re-usability and simplify maintenance.

@Cherser-s
Copy link
Contributor Author

Cherser-s commented Jun 23, 2019

Ok, but there is probably no need to implement relative pointer extension in SCTK, except for modifying Environment struct.

Also, adding relative pointer will require DeviceEvent queue. Now only WindowEvent queue is implemented. I've simply added DeviceEventsSink Cherser-s@eabe813.

@elinorbgr
Copy link
Contributor

Well, I hadn't really started to look into these protocols so this was kind of a generic response. If you already have a working implementation, this will be easier to discuss with a PR though.

@Cherser-s
Copy link
Contributor Author

Ok, I wrote implementation yesterday evening though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DS - wayland S - api Design and usability S - enhancement Wouldn't this be the coolest?
Development

Successfully merging a pull request may close this issue.

3 participants