Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redraw Requested not issued for glutin examples (winit examples too?) until at least one other event has been issued. #987

Closed
goddessfreya opened this issue Jun 26, 2019 · 9 comments
Labels
B - bug Dang, that shouldn't have happened C - needs investigation Issue must be confirmed and researched DS - x11
Milestone

Comments

@goddessfreya
Copy link
Contributor

The glutin examples for some reason don't draw until you've moved the mouse or pressed a key at least once. I suspect this is a winit bug. Found while testing out #925 .

@goddessfreya goddessfreya added B - bug Dang, that shouldn't have happened DS - x11 C - needs investigation Issue must be confirmed and researched labels Jun 26, 2019
@felixrabe
Copy link
Contributor

felixrabe commented Jun 26, 2019

This is probably related to an issue I see in EL 2.0 on macOS (legacy examples work fine in that regard).

Most examples work like this: I press the window's close button - nothing happens - I move the mouse slightly - window closes.

I suspect returning ControlFlow::Exit only really causes the loop to exit after another event has been received. Maybe there is a code ordering error in the event loop logic.

@murarth
Copy link
Contributor

murarth commented Jun 26, 2019

Is this running on winit master? Because it sounds like the kind of bug I expected from #982, but didn't show up for me in testing.

@goddessfreya
Copy link
Contributor Author

Yes, was done against master.

@felixrabe
Copy link
Contributor

@zegentzy On what platform(s)?

If Linux/X11, did #982 cause this (i.e. commit 29e2481) or is the issue also visible with the commit before (3555de1)?

@goddessfreya
Copy link
Contributor Author

Issue was present before #982, on x11. I'm afraid I lack time to git bisect this issue.

@sumit0190
Copy link

I only discovered this after setting Poll to Wait in my logic.

I thought manually calling request_redraw after catching it from an EventsCleared event would work, but turns out it doesn't (for Wait; Poll has been working correctly for me with that approach).

@Osspial
Copy link
Contributor

Osspial commented Dec 28, 2019

Have any of the various bugfixes we've made in the past six months or so addressed this?

@kettle11
Copy link

I ran into this issue today when experimenting with Glutin examples.

@kchibisov
Copy link
Member

I think this is fixed in some form.

Though, it'll be fixed once #2900 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened C - needs investigation Issue must be confirmed and researched DS - x11
Development

No branches or pull requests

7 participants