Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdav: add some credential feature #1298

Open
Tofee opened this issue Oct 6, 2024 · 1 comment
Open

webdav: add some credential feature #1298

Tofee opened this issue Oct 6, 2024 · 1 comment
Labels
A-commands Area: Related to commands in `rustic` A-security Area: Security related C-enhancement Category: New feature or request

Comments

@Tofee
Copy link

Tofee commented Oct 6, 2024

Currently, when rustic webdav is started, the webdav access is open to everyone.

It would be nice to have an option to protect this access with a login/passowrd. We could even think of a simple protection, with the login begin whatever, and the password the same as the repository password.

What is your view on this?

@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Oct 6, 2024
@simonsan
Copy link
Contributor

simonsan commented Oct 6, 2024

I think this is related to adding TLS support for webdav. If we implement a simple user/password authentication, this doesn't help much if on your intranet others can see the traffic and just read the credentials.

But anyway, webdav is done by the warp crate (which we might refactor to axum at some point) at the moment - if anyone wants to add improvements, they will be very local at the place where warp is called.

Originally posted by @aawsome in #1271 (comment)

@simonsan simonsan added C-enhancement Category: New feature or request A-security Area: Security related A-commands Area: Related to commands in `rustic` and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-commands Area: Related to commands in `rustic` A-security Area: Security related C-enhancement Category: New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants