Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Repository impl by state #347

Open
simonsan opened this issue Nov 3, 2024 · 0 comments
Open

Split Repository impl by state #347

simonsan opened this issue Nov 3, 2024 · 0 comments
Labels
A-dx Area: Related to Developer Experience A-repository Area: Related to the Repository API C-enhancement Category: New feature or request C-refactor Category: Refactoring of already existing code

Comments

@simonsan
Copy link
Contributor

simonsan commented Nov 3, 2024

Repository is ~2k LOC. I think it's not easy to navigate, especially given the generic implementations. I think it would be good, to split that file by the state of the implementation into submodules. E.g., repository/open.rs, so we know directly, that this is only containing impls for an open repository.
@simonsan simonsan added C-enhancement Category: New feature or request A-dx Area: Related to Developer Experience C-refactor Category: Refactoring of already existing code labels Nov 3, 2024
@simonsan simonsan added the A-repository Area: Related to the Repository API label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dx Area: Related to Developer Experience A-repository Area: Related to the Repository API C-enhancement Category: New feature or request C-refactor Category: Refactoring of already existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonsan