Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrypt error rework #396

Open
simonsan opened this issue Jan 6, 2025 · 1 comment
Open

scrypt error rework #396

simonsan opened this issue Jan 6, 2025 · 1 comment
Labels
A-errors Area: error handling needs improvement C-refactor Category: Refactoring of already existing code

Comments

@simonsan
Copy link
Contributor

simonsan commented Jan 6, 2025

"Invalid scrypt parameters. Please check the key file and password.",

Error needs own error code, with link to docs.

old restic versions used invalid scrypt parameters which are not (and I think will never be) supported by rustic

proposed workaround is to recreate the key in restic

Ref.: rustic-rs/rustic#1394

@simonsan simonsan added A-errors Area: error handling needs improvement C-refactor Category: Refactoring of already existing code labels Jan 6, 2025
@aawsome
Copy link
Member

aawsome commented Jan 7, 2025

As written in rustic-rs/rustic#1394 I propose to wait with this until we get a decision from the Rust Crypto team about how they'll treat this. As there is already a RFC errata and this issue also occurs in e.g. etherium implementations, IMO there is a good chance this check will be relaxed in upstream and we won't see this error anymore in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-errors Area: error handling needs improvement C-refactor Category: Refactoring of already existing code
Projects
None yet
Development

No branches or pull requests

2 participants