Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release TLSAcceptor #209

Closed
robinfriedli opened this issue Jun 30, 2023 · 2 comments · Fixed by #210
Closed

Release TLSAcceptor #209

robinfriedli opened this issue Jun 30, 2023 · 2 comments · Fixed by #210

Comments

@robinfriedli
Copy link

I was following the server example and noticed that TLSAcceptor from #186 hasn't actually been released yet. I'm currently pulling the dependency off of GitHub instead of crates.io as an alternative but it would be great if you could publish a new release, provided there are no blocking issues.

@robinfriedli
Copy link
Author

Also, slightly off topic, I was wondering how the TLSAcceptor (or TlsStream in general) handles invalid data in the request, does it log an error or terminate the hyper server?

@djc
Copy link
Member

djc commented Jul 4, 2023

The TlsAcceptor type merely implements hyper's Accept trait -- it does not log errors but yields them to the caller. Review the hyper documentation to determine what hyper does when the Accept impl returns an error.

@djc djc mentioned this issue Jul 4, 2023
6 tasks
@djc djc closed this as completed in #210 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants