Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TryFrom<u32> for rustls_error #198

Closed
jsha opened this issue Nov 9, 2021 · 1 comment
Closed

Implement TryFrom<u32> for rustls_error #198

jsha opened this issue Nov 9, 2021 · 1 comment

Comments

@jsha
Copy link
Collaborator

jsha commented Nov 9, 2021

In #195, we added a TryFrom<u32> for rustls_error by way of a derive macro in the num_enum package. It would be nice not to need the extra dependency, though. We should investigate ways to do this transformation ourselves, in a way that ensures we cover all numeric codes and match them to the correct enum variant.
@jsha jsha mentioned this issue Nov 9, 2021
Merged
@cpu
Copy link
Member

cpu commented Oct 4, 2024

We replaced num_enum with 7c12430 so I think we can call this one done ™️

@cpu cpu closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsha @cpu