-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a container for miri tests #61
Comments
Given the UB found in #195, probably good to prioritize this? |
Good to prioritize, but worth noting that Miri wouldn't have caught the UB in #195. That UB occurred at the FFI boundary, but Miri only handles Rust. To catch it we would have needed Rust tests that explicitly exercised the case of creating an invalid enum to pass to rustls_error. It looks like Miri now provides instructions on how to include it in CI while accounting for the problem that it doesn't exist in all nightly builds: https://github.com/rust-lang/miri#running-miri-on-ci To properly exercise our code, under Miri, we'll want to write a bunch more unittests on the Rust side. It would also be good to have an integration test that acts like client.c / server.c. However:
Fortunately the read_tls / write_tls interfaces in rustls don't require writing to an actual network, so we can just simulate a network connection with a pair of buffers. |
Done in #199. We didn't wind up needing to create a container. 🎉 |
Right now we're getting this error for the miri tests:
We should build a container with a given version of nightly that we know has the miri component, so we're not vulnerable to breakages like this. That would also be beneficial for build times, since right now we build some things for the miri test job, and that's slow.
The text was updated successfully, but these errors were encountered: