-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.102 release planning #159
Comments
Added a few more items to the list (most of which are already merged). |
Almost there 🎉 |
I think we should defer releasing the final version of this until the final rustls release is also ready, in order to avoid creating more semver-incompatible version branches (that we have to maintain according to our maintenance policy) if it still turns out that we have some churn in the API we want for rustls. |
That sounds good to me. |
Thought about the requirements before release some more, added 3 items. |
We chatted about this one in a Discord thread. Making this change will require moving a lot of types into The line-item mentions leaking types into the rustls API but presently the webpki revocation types only appear in the webpki verifier bits that are already specific to webpki. The rustls/rustls#1430 issue that may have motivated this change can be accomplished by wrapping the webpki verifier so it doesn't seem like it would justify the work involved. In sum: I think we're going to table this idea for the 0.22 release and encourage 1430 be solved with other workarounds. |
That would include I guess moving this up could theoretically be a non-breaking change? In the sense that both webpki and rustls could reexport the moved type? That is assuming the type we move is a superset of |
Aside from some release engineering (taking pki-types to 1.0, editing versions here) I think this is done? |
Yeah, I think so! |
Let's gather some context for release blockers
Done:
Budget
inCertRevocationList
trait.PushRevocationOptions
into pki-types to avoid public webpki type in rustls API?The text was updated successfully, but these errors were encountered: