Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parity-util-mem soundness #1399

Closed
pinkforest opened this issue Aug 30, 2022 · 3 comments · Fixed by #1528
Closed

parity-util-mem soundness #1399

pinkforest opened this issue Aug 30, 2022 · 3 comments · Fixed by #1528
Labels
Unsound Informational / Unsound

Comments

@pinkforest
Copy link
Contributor

pinkforest commented Aug 30, 2022

Came across while investigating this: #1394

paritytech/parity-common#364

Both Github repository and crates.io readme contains a big warning:
https://github.com/paritytech/parity-common/tree/master/parity-util-mem
https://crates.io/crates/parity-util-mem

Cheers

@pinkforest pinkforest changed the title parity-util-mem UB parity-util-mem soundness Aug 30, 2022
@pinkforest pinkforest added the Unsound Informational / Unsound label Aug 30, 2022
@pinkforest
Copy link
Contributor Author

pinkforest commented Jan 15, 2023

Hmm:

There is movement away from it not sure about the status of this crate.
@alvicsam and @ordian - are people supposed to use this crate or should we flag this as unmaintained ?

@ordian
Copy link
Contributor

ordian commented Jan 15, 2023

parity-util-mem is no longer maintained.

It was never meant to be a general-purpose crate and only was used in substrate ecosystem, which no longer depends on it. I can make a patch release (some time next week) which warns users about its usage in README and marks it as unmaintained.

There are probably some alternatives like https://github.com/bholley/malloc_size_of_derive.

@pinkforest
Copy link
Contributor Author

Cool thanks no worries - we'll just nudge anyone using not to use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unsound Informational / Unsound
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants