Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a qualified path in affected.functions #512

Closed
Qwaz opened this issue Dec 5, 2020 · 2 comments
Closed

Support a qualified path in affected.functions #512

Qwaz opened this issue Dec 5, 2020 · 2 comments

Comments

@Qwaz
Copy link
Contributor

Qwaz commented Dec 5, 2020

Continued from: #320 (comment)

Supporting a qualified path in affected.functions field would allow to describe the affected functions more precisely, especially when the bug is inside a trait implementation.

@tarcieri
Copy link
Member

tarcieri commented Dec 7, 2020

I relaxed the checks for the contents of this field quite a bit in rustsec crate v0.22, but this case is still disallowed.

I'm thinking in the next release we can remove pretty much all of the validity checks from this field and move them into the linting process so they're easy to change.

Note that we still won't be able to populate this field with anything that breaks the current rules until all clients have updated, however.

@pinkforest
Copy link
Contributor

This works today now with latest rustsec:

RUSTSEC-0000-0000.md
functions = { "mycrate::MyType::<impl>Clone::clone" = ["< 1.2.0, >= 1.1.0"] }

$ rustsec-admin lint . --skip-namecheck rustdecimal|grep 0000
Linted ok: ./crates/mycrate/RUSTSEC-0000-0000.md

From code all I see now in checks is that the initial mycrate:: matches crate name mycrate

Closing as completed - We can re-open in rustsec/rustsec if further changes etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants