Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document MSRV #3114

Closed
71 opened this issue Oct 13, 2022 · 0 comments · Fixed by #4038
Closed

Document MSRV #3114

71 opened this issue Oct 13, 2022 · 0 comments · Fixed by #4038

Comments

@71
Copy link

71 commented Oct 13, 2022

Motivation

I'm adding a feature to wasm-bindgen (opening a PR soon), but don't know against which version of Rust I should check my changes. Clearly documenting the Minimum Supported Rust Version would help me test my changes.

Proposed Solution

As .github/workflows/main.yml uses Rust 1.56 for one of the tests, maybe we could start with this version? Then we could document it in the README, and/or by adding a rust-version field to Cargo.toml (which incidentally is supported on Rust 1.56 and up).

Alternatives

There may be other ways to document the MSRV, but "MSRV" itself has become a fairly common keyword to look for that information, so I'd like for it to be surfaced in the README and in Cargo.toml.

Additional Context

N/A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant