Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support namespace attributes in the webidl frontend #746

Closed
fitzgen opened this issue Aug 23, 2018 · 3 comments
Closed

Support namespace attributes in the webidl frontend #746

fitzgen opened this issue Aug 23, 2018 · 3 comments
Labels
frontend:webidl Issues related to the WebIDL frontend to wasm-bindgen help wanted We could use some help fixing this issue!

Comments

@fitzgen
Copy link
Member

fitzgen commented Aug 23, 2018

We don't yet support attributes within namespaces:

namespace Whatever {
    readonly attribute bool blah;
}

Note that attributes within namespaces are always readonly.

Would need to add support here: https://github.com/rustwasm/wasm-bindgen/blob/master/crates/webidl/src/lib.rs#L926

@fitzgen fitzgen added help wanted We could use some help fixing this issue! frontend:webidl Issues related to the WebIDL frontend to wasm-bindgen Rust 2018 Release Candidate labels Aug 23, 2018
@fitzgen
Copy link
Member Author

fitzgen commented Aug 23, 2018

This might be a blocker for #613 -- I need to check how often this happens in practice and how important the instances are.

@fitzgen
Copy link
Member Author

fitzgen commented Aug 23, 2018

This might be a blocker for #613 -- I need to check how often this happens in practice and how important the instances are.

There aren't any in our enabled webidls. Don't think this is a blocker!

@alexcrichton
Copy link
Contributor

Since this doesn't show up in any of our webidl and it doesn't look like namespaces are really used much any more I'm gonna go ahead and close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend:webidl Issues related to the WebIDL frontend to wasm-bindgen help wanted We could use some help fixing this issue!
Projects
None yet
Development

No branches or pull requests

2 participants