Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataView endian parameters #960

Closed
katis opened this issue Oct 12, 2018 · 2 comments
Closed

DataView endian parameters #960

katis opened this issue Oct 12, 2018 · 2 comments

Comments

@katis
Copy link
Contributor

katis commented Oct 12, 2018

DataView doesn't support the littleEndian boolean parameter, and as such everything is written as big endian.

I could do this as a practice issue next week, but I'd like to know if there should be a new method (set_int32_endian or something) or just add the boolean parameter to the end for every method that needs it?

@alexcrichton
Copy link
Contributor

Thanks for the report! It should definitely be ok to simply add new methods here which exposes the boolean parameters, and tacking on _endian to the end sounds good to me as well!

If you need any help with adding these just let us know!

@katis
Copy link
Contributor Author

katis commented Oct 15, 2018

Fixed with #966

@katis katis closed this as completed Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants