Fixing require to be ignored by Webpack #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR is included in was-bindgen v0.2.61. The webpack compilation error is still there. |
|
@BenoitDel It is not included in 0.2.61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bundlers (such as Webpack) will process
requireeven if it's inside of a conditional branch. Since we only want therequireto run in Node, we want Webpack to completely ignore it. Usingmodule.requireseems to be the best way to do that.I would really rather just remove the
requirecompletely, but NodeJS 10 is supported until 2021-04-01, so we can't remove it until then.Fixes #2116