Quote names containing colons in generated .d.ts #4488
Conversation
lynn
changed the title
| readonly __wbindgen_export_0: WebAssembly.Table; | ||
| readonly "__wbgt__reference_test::example_test": (a: number) => void; | ||
| readonly __wbgtest_cov_dump: () => [number, number]; |
There was a problem hiding this comment.
The fix is visible here :) __wbgt__reference_test::example_test is quoted now. 🎉
|
This still seems to be failing CI unfortunately. |
|
Finally just looks like the fixtures still just need to be rerun with a bless flag to update the expected output. |
Sorry, I'm not totally sure what that means or (if it is something I'm supposed to do) how to achieve it. Is there a command I can try running? |
|
Yes, you can run: |
| module_export_types(module, |name, ty| { | ||
| writeln!(exports, " readonly {name}: {ty};").unwrap(); | ||
| if name.contains(':') { | ||
| writeln!(exports, " readonly {name:?}: {ty};").unwrap(); |
There was a problem hiding this comment.
Its not entirely clear on first glance whats going on here. I think a comment would help.
| #[wasm_bindgen_test] | ||
| fn example_test() { | ||
| assert_eq!(example_128(1), None) | ||
| } |
There was a problem hiding this comment.
I assume this is leftover from when you were debugging?
Fixes #4449.
The change to crates/cli/tests/reference/wasm-export-types.rs reproduces the issue in a test. The change to wasm2es6js.rs fixes it.