Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

must match wasm-bindgen versions exactly #272

Closed
xmclark opened this issue Aug 28, 2018 · 1 comment
Closed

must match wasm-bindgen versions exactly #272

xmclark opened this issue Aug 28, 2018 · 1 comment

Comments

@xmclark
Copy link
Contributor

xmclark commented Aug 28, 2018

🐛 Bug description

wasm-pack does not do what I expect when choosing to install wasm-bindgen. wasm-pack requires the version of wasm-bindgen installed and the one specified in the application's Cargo.toml to match exactly. A package with a partial version (e.g. 0.2 or 1) do not match liberally with an installed version of wasm-bindgen.

🤔 Expected Behavior

I would expect the partial version to match liberally. Specifying a version of "1" would match 1 := 1.x.x := >=1.0.0 <2.0.0.

👟 Steps to reproduce

  1. Install 0.2.17 of wasm-bindgen
  2. Checkout master.
  3. Make a local test project that does wasm-bindgen stuff.
  4. Set the version of wasm-bindgen in Cargo.toml to "0.2"
  5. Run wasm-pack on the directory

The wasm-bindgen binary will not be found and it will begin installing one.

Switch the installed version to "0.2.17".

It finds the globally installed instance. It works.

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: d5bf5a3
rustc version: rustc 1.30.0-nightly (33b923fd4 2018-08-18)

@fitzgen
Copy link
Member

fitzgen commented Aug 28, 2018

We must match the wasm-bindgen version used to in cargo build exactly (ish) and the way to do that properly is #270. That will also allow cargo to choose a semver compatible version of wasm-bindgen, and also for wasm-pack to use that exact version.

Going to close this as a duplicate of that issue -- thanks for taking the time to file an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants