Skip to content

Preserve existing .gitignore file in out directory #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sinking-point
Copy link

Closes #984 .

Rather than check for an existing .gitignore before creating one, I opted to use create_new and check the error. This makes it atomic - it'll probably never matter, but hey.


Make sure these boxes are checked! 📦✅

  • [✅] You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • [✅] You ran cargo fmt on the code base before submitting
  • [✅] You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@andrewhamon
Copy link

andrewhamon commented Feb 21, 2025

This is much needed in a monorepo. We want to check some files (like d.ts) so that typescript can function as normal without needing to depend on a rust toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't overwrite an existing .gitignore file
2 participants