Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vergen-gix does not consider the matches patterns when emitting describe output #363

Open
SanchithHegde opened this issue Aug 11, 2024 · 1 comment

Comments

@SanchithHegde
Copy link
Contributor

The vergen-gix crate does not consider the matches patterns specified when emitting the describe output. The describe_match_pattern field is just not being read anywhere in the vergen-gix/src/gix/mod.rs file (it is being set in describe() though) as of opening this issue.

I couldn't find a way to pass the match patterns to gitoxide based on what I could search and based on the gitoxide docs. Let me know if I missed something, I can open a PR if there's a way to pass these patterns.

@nstinus
Copy link

nstinus commented Nov 20, 2024

I just stumbled upon this. Until this is supported, IMHO it would be better to remove describe_match_pattern to avoid any confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants