Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Byte Size Calculation in MiniUserInfo Class #2090

Open
coderabbitai bot opened this issue Aug 22, 2024 · 0 comments
Open

Incorrect Byte Size Calculation in MiniUserInfo Class #2090

coderabbitai bot opened this issue Aug 22, 2024 · 0 comments
Assignees
@drazisil

Comments

@coderabbitai
Copy link

coderabbitai bot commented Aug 22, 2024

The byte size calculation in the getByteSize method of the MiniUserInfo class in packages/nps/messageStructs/MiniUserList.ts is incorrect. The current calculation includes an extra 4 bytes. The correct calculation should be 4 + this.userName.length + 1.

Please refer to the pull request for more details: #2037

Comment URL: #2037 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drazisil drazisil

Labels
None yet
Projects
Rusty Motors Tracking
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drazisil