New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace inherits with class #105

Open

jimmywarting opened this issue Aug 18, 2021 · 1 comment

jimmywarting commented Aug 18, 2021

looking to reduce our sup dependencies, are you willing to accept a PR that switches the code space to newer class \w extend?

Collaborator

mcollina commented Aug 18, 2021

That's not needed. You can replace inherits with https://github.com/nodejs/node/blob/7ca38f05a023666274569343f128c5aed81599f3/lib/internal/streams/writable.js#L70-L71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment