@types/readable-stream should be moved to dev dependencies

[edgardcooper-thomasdhondt]

Currently @types/readable-stream is listed as a dependency, this should be listed as a dev dependency.

[guyellis]

@edgardcooper-thomasdhondt I assume that you're calling this out because of an issue from TypeScript like:

error TS2420: Class 'Readable' incorrectly implements interface 'ReadableStream'.
  Types of property 'wrap' are incompatible.
    Type '(oldStream: Readable) => this' is not assignable to type '(oldStream: ReadableStream) => this'.
      Types of parameters 'oldStream' and 'oldStream' are incompatible.
        Type 'ReadableStream' is not assignable to type 'Readable'.
          Type 'ReadableStream' is missing the following properties from type 'Readable': readableAborted, readableDidRead, readableEncoding, readableEnded, and 28 more.

419     class Readable extends _Readable implements NodeJS.ReadableStream {

which is caused because of this dependency tree:

└─┬ mssql@11.0.1
  └─┬ tedious@18.2.1
    └─┬ bl@6.0.13
      └── @types/readable-stream@4.0.14

I'm wondering if bl can be removed or replaced in tedious to get around this? I haven't looked at the tedious code so not sure how tricky that is.

Or do you have a different dependency tree that's tripping you up?

[edgardcooper-thomasdhondt]

Exactly, that error is what brought me here.

Removing bl from tedious would also fix the issue of course, but the root of the issue appears to be in this repo.

Until this gets fixed, we fixed our deployment issue by downgrading the typescript version to 5.4.2 in our project.

[Llorx]

Hello, how is this going?