Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use outcome.get_result() in hookwrapper #1

Closed
The-Compiler opened this issue May 31, 2016 · 1 comment
Closed

Use outcome.get_result() in hookwrapper #1

The-Compiler opened this issue May 31, 2016 · 1 comment

Comments

@The-Compiler
Copy link

Using outcome.result instead of outcome.get_result() will cause an AttributeError when there was an exception inside the wrapped hook which will hide the real exception.

See e.g. pytest-dev/pytest-qt#98
@The-Compiler The-Compiler mentioned this issue May 31, 2016
Closed
@rvprasad
Copy link
Owner

Thanks for the catch. I have fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@The-Compiler @rvprasad