Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usewgridder no effective from wsclean v3.4 onwards #115

Closed
botteon opened this issue Mar 7, 2024 · 3 comments
Closed

usewgridder no effective from wsclean v3.4 onwards #115

botteon opened this issue Mar 7, 2024 · 3 comments

Comments

@botteon
Copy link
Contributor

botteon commented Mar 7, 2024

Hi,

just to point out that --usewgridder has no effect if wsclean v3.4 is used, as since this version wgridder is the default gridder: you will end up using wgridder in facetselfcal even without setting --usewgridder in the parser!

@rvweeren
Copy link
Owner

Yeh, I'll remove it from the option list in the next update round.

@botteon
Copy link
Contributor Author

botteon commented Mar 24, 2024

What about a --gridder option which is set to wgridder by default? Instead of --usewgridder and --idg one could just have to set --griddger wgridder and --gridder idg. By looking at the code, this should be doable.
In some wsclean versions, wgridder does not work if channel frequencies are sorted in descending order (e.g. in the GMRT), so one has to use wstacking. I think that this issue was solved in the current wsclean, but this edit would make the code work also with older wsclean versions. Now the usage of the gridder is ambiguous in facetselfcal because it depends on the wsclean version used...
Generally, at some point the code should check at the beginning of the run that the wsclean in the system is not too old...

@rvweeren
Copy link
Owner

The --usewgridder option has been removed (if needed a gridder option can be added back in a future version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants